Skip to content

Add PR merge action#9283

Merged
felicitymay merged 2 commits intogithub:mainfrom
BryanLa:patch-2
Aug 31, 2021
Merged

Add PR merge action#9283
felicitymay merged 2 commits intogithub:mainfrom
BryanLa:patch-2

Conversation

@BryanLa
Copy link
Copy Markdown
Contributor

@BryanLa BryanLa commented Aug 24, 2021 •
edited
Loading

Why:

The action/permissions table is missing PR merge

What's being changed:

Adding a "Merge a pull request" action, with appropriate permissions levels.

Check off the following:

  • I have reviewed my changes in staging (look for the latest deployment event in your pull request's timeline, then click View deployment).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@welcome
Copy link
Copy Markdown

welcome Bot commented Aug 24, 2021

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions Bot added the triage Do not begin working on this issue until triaged by the team label Aug 24, 2021
@ramyaparimi ramyaparimi added actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team actions This issue or pull request should be reviewed by the docs actions team labels Aug 25, 2021
@ramyaparimi
Copy link
Copy Markdown
Contributor

ramyaparimi commented Aug 25, 2021

@BryanLa
Thanks so much for opening a PR! I'll get this triaged for review ⚡

felicitymay
felicitymay approved these changes Aug 31, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@felicitymay felicitymay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BryanLa - thanks for spotting and fixing this omission in the docs 💖

Your change looks great 🚀

@felicitymay felicitymay merged commit 8fdaf9c into github:main Aug 31, 2021
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 31, 2021

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@felicitymay felicitymay felicitymay approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BryanLa @ramyaparimi @felicitymay